search

mwaylabs / generator-m-ionic

Advanced workflows and setup for building rock-solid Ionic apps
MIT License
671 stars 135 forks source link

fix missing karma jasmine dependency #506

Closed funkybaboon closed 7 years ago

funkybaboon commented 7 years ago

This fixes the warning of a missing dependency warning "karma-jasmine@1.1.0" has unmet peer dependency "jasmine-core@*". when running yarn on a new generator-m project.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.744% when pulling b123caa74a66b4ab80ce468f13ed00e8f637b6db on funkybaboon:bugfix/fix_missing_karma-jasmine_dependency into c21f54527881795a12bc4366f2f2a10ae1f7c8de on mwaylabs:master.

gruppjo commented 7 years ago

Hi @funkybaboon. This is rather a problem of the karma-jasmine dependency and since all the tasks run fine without the peer-dep, I'd rather not include it. If this is important to you, you could investigate over at the karma-jasmine repo why they require this peer-dep.

Additionally, this is the wrong package.json file. The template of package.json of the generated project is here: https://github.com/mwaylabs/generator-m-ionic/blob/master/generators/app/templates/package.json