mwbrooks / cordova-plugin-menu

Native Menu Plugin for Apache Cordova and PhoneGap.
MIT License
67 stars 33 forks source link

Use Common PhoneGap.exec #24

Closed mwbrooks closed 12 years ago

mwbrooks commented 12 years ago

If possible, it would be nice if iOS can use the universal PhoneGap.exec interface. I'm not sure where this is at for iOS, but I cannot find any "core" APIs using the interface.

For example, instead of:

PhoneGap.exec("NativeControls2.updateToolBarItem", data['data-uuid'], { 'label': data['label'] });

use

PhoneGap.exec(
    successCallback,
    failCallback,
    "com.phonegap.menu.toolbar",
    "label",
    [ data["label"] ]
);
shazron commented 12 years ago

Fixed in https://github.com/nitobi/phonegap-plugin-menu/pull/26

mwbrooks commented 12 years ago

Commit 036e26408b3f84b00d30fbd548f31ac279b56298