search

mwcproject / mwc-node

Mimblewimble applied in the base layer. Scarce, censorship resistant, durable, indestructible, salable, portable, fungible, private & divisible.‍ Good money.
https://mwc.mw/
Apache License 2.0
33 stars 26 forks source link

fix rangeproof cache #38

Closed snape479 closed 4 months ago

snape479 commented 3 years ago

This pull request re-enables the verifier_cache with fixes to avoid the inflation bug. It also includes two tests. The 'test_overflow_cached_rangeproof' test can be run against checkins before the verifier_cache was disabled to confirm failure prior to that change.

suemto commented 3 years ago

The fix looks good for me. Thanks @snape479

But I would propose to hold this fix, since we share the same codebase as Grin but Grin probably remove the whole cache in a PR (https://github.com/mimblewimble/grin/pull/3628).

bayk commented 4 months ago

At versions 5.3 the cache is removed form the node at grin and in mwc-node. Closing this PR because of this