Fixes calculating the total number of coinbase rewards at the last block reward height

mwcproject / mwc-node

Mimblewimble applied in the base layer. Scarce, censorship resistant, durable, indestructible, salable, portable, fungible, private & divisible.‍ Good money.

https://mwc.mw/

Apache License 2.0

33 stars 26 forks source link

Fixes calculating the total number of coinbase rewards at the last block reward height #49

Closed NicolasFlamel1 closed 5 months ago

NicolasFlamel1 commented 2 years ago

Fixes calculating the total number of coinbase rewards at the last block reward height.

bayk commented 5 months ago

Thank you @NicolasFlamel1 , good catch.

Here is a test for this fix: https://github.com/mwcproject/mwc-node/commit/2a1206a15db0b50d194dae812644a7d183d92721

Test is failing (including the test_rewards_full_cycle) at the last block without the patch and and passing well with those changes.

The PR is merged, the branch with test I will rebase to make the test to pass.