search

mwcproject / mwc-wallet

MWC Wallet for Full Node
Apache License 2.0
18 stars 22 forks source link

Increase network read timeout #15

Closed NicolasFlamel1 closed 2 years ago

NicolasFlamel1 commented 2 years ago

This change increases the network read timeout to 10 minutes to avoid timing out too early when exchanging a slate with a device that takes longer than 20 seconds to generate a reply.

This will improve interoperability with wallets that support the MimbleWimble Coin Ledger app since that app takes approximately 90 seconds to generate a bulletproof.

vekamo commented 2 years ago

Hey @NicolasFlamel1, Firstly thanks for the PR and sorry for the late response. I feel we should not change this timeout. In case of reverse proxy with an offline wallet, the sender need to wait 10min. That's not good for the UX. Maybe up it to 4mins and even with that i don't feel it well or just make the ledger app accepting slatepack or files? What do you think overvall?