mwcproject / mwcbuildpipeline

MIT License
1 stars 4 forks source link

links to explorer are pointing to different domain thus returning not found #11

Closed cgilliard closed 4 years ago

cgilliard commented 5 years ago

Please change to relative paths.

cgilliard commented 5 years ago

See screenshot (notice url is explorer.floonet.mwc.mw and links are to explorer.mwc.mw.

Screen Shot 2019-09-11 at 9 31 25 PM
hcasalet commented 5 years ago

Chris,

This comes from the proof file itself. The test file that you gave me has explorer.mwc.mw in it? Please look at the lines in VerifyProof.java (line 85-112). We need to use a different test file?

Since this is a full link in the middle of the page, we cannot use relative path, but have to hostname:port# in the java file in order to have correct link?

Thanks, Holly

cgilliard commented 5 years ago

Ok thanks. Fix needs to be in the wallet. Will open a bug for that.

On Sun, Sep 15, 2019, 10:21 PM Holly Casaletto notifications@github.com wrote:

Chris,

This comes from the proof file itself. The test file that you gave me has explorer.mwc.mw in it? Please look at the lines in VerifyProof.java (line 85-112). We need to use a different test file?

Since this is a full link in the middle of the page, we cannot use relative path, but have to hostname:port# in the java file in order to have correct link?

Thanks, Holly

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/11?email_source=notifications&email_token=ABXFVNZBPSXCJGDN4ROQB4DQJ4JVHA5CNFSM4IV4JJO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YEAOQ#issuecomment-531644474, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXFVNZ3UYBIDXEB2XQGTSDQJ4JVHANCNFSM4IV4JJOQ .

ajcryptoR18 commented 4 years ago

This file has changed since Sep. Is the issue still exist? In my local environment, I am not able to see this issue. (https://localhost:8445/VerifyProof). Where I can reproduce this issue?

hcasalet commented 4 years ago

Don't worry about this issue. This is not for Block Explorer as it turns out. Chris, do you want to move this issue away and close it from here? Thanks.

cgilliard commented 4 years ago

Closing. This was fixed in the Qt wallet.