Closed cgilliard closed 4 years ago
Fixed on topic/hcasaletto/more_on_be. Will deploy it on AWS machine tomorrow.
The block number is already there. See the column to the rightmost.
I think that relates to another issue right?
Did I misunderstand it?
On Thu, Nov 28, 2019 at 11:33 AM cgilliard notifications@github.com wrote:
I think that relates to another issue right?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENBG45R6HCCJOF4D55TQWAMHJA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNKU4A#issuecomment-559590000, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENAZIONWQPAT2O7TVITQWAMHJANCNFSM4I2TLTFA .
I think your last comment is about this issue: https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENGYATVUYQ46XCAJAVLQWAOZ5A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNLOFI#issuecomment-559593237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA .
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto notifications@github.com wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENGYATVUYQ46XCAJAVLQWAOZ5A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNLOFI#issuecomment-559593237 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVN5CGDTEAPIFZKEMPETQWAP2ZA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNLYGQ#issuecomment-559594522, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA .
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto <notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVN5CGDTEAPIFZKEMPETQWAP2ZA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNLYGQ#issuecomment-559594522 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENCJDQ4IZPRZJKXPA73QWAQ2DA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNMBAQ#issuecomment-559595650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA .
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto <notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVN5CGDTEAPIFZKEMPETQWAP2ZA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNLYGQ#issuecomment-559594522 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENCJDQ4IZPRZJKXPA73QWAQ2DA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNMBAQ#issuecomment-559595650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA .
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto notifications@github.com wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENCJDQ4IZPRZJKXPA73QWAQ2DA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNMBAQ#issuecomment-559595650 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNYW5FIEBZEUGHYLCUTQWA2L7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNOVSA#issuecomment-559606472, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA .
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto notifications@github.com wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard notifications@github.com wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENCJDQ4IZPRZJKXPA73QWAQ2DA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNMBAQ#issuecomment-559595650 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNYW5FIEBZEUGHYLCUTQWA2L7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNOVSA#issuecomment-559606472, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA .
Yeah, height requires a bit more work than offset. I will change to use height then.
Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNYW5FIEBZEUGHYLCUTQWA2L7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNOVSA#issuecomment-559606472 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENHSF44NTS5KJECOWH3QWEGUPA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZPYI#issuecomment-559781857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA .
Fixed and re-deployed on AWS 34.238.121.224. Please check.
Thanks, Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNYW5FIEBZEUGHYLCUTQWA2L7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNOVSA#issuecomment-559606472 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENHSF44NTS5KJECOWH3QWEGUPA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZPYI#issuecomment-559781857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA .
Yes, it worked thanks!
On Sat, Nov 30, 2019 at 3:09 PM Holly Casaletto notifications@github.com wrote:
Fixed and re-deployed on AWS 34.238.121.224. Please check.
Thanks, Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard notifications@github.com wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENHSF44NTS5KJECOWH3QWEGUPA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZPYI#issuecomment-559781857 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNZA3CZ6JHINXPSGMLTQWLXA7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQVXGQ#issuecomment-560028570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVN7KLTKFPZU6ZPVOGYTQWLXA7ANCNFSM4I2TLTFA .
Is there a way to make it not appear until you click the next button? I'm thinking it makes the url look a little populated if it's always there.
On Sat, Nov 30, 2019 at 4:39 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Yes, it worked thanks!
On Sat, Nov 30, 2019 at 3:09 PM Holly Casaletto notifications@github.com wrote:
Fixed and re-deployed on AWS 34.238.121.224. Please check.
Thanks, Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard <notifications@github.com
wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENHSF44NTS5KJECOWH3QWEGUPA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZPYI#issuecomment-559781857 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNZA3CZ6JHINXPSGMLTQWLXA7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQVXGQ#issuecomment-560028570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVN7KLTKFPZU6ZPVOGYTQWLXA7ANCNFSM4I2TLTFA .
Changed to not show until someone clicks next.
On Sat, Nov 30, 2019 at 4:43 PM cgilliard notifications@github.com wrote:
Is there a way to make it not appear until you click the next button? I'm thinking it makes the url look a little populated if it's always there.
On Sat, Nov 30, 2019 at 4:39 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Yes, it worked thanks!
On Sat, Nov 30, 2019 at 3:09 PM Holly Casaletto < notifications@github.com> wrote:
Fixed and re-deployed on AWS 34.238.121.224. Please check.
Thanks, Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard < notifications@github.com
wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVNZA3CZ6JHINXPSGMLTQWLXA7A5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQVXGQ#issuecomment-560028570 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXFVN7KLTKFPZU6ZPVOGYTQWLXA7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENBHF6BEVMVKZ2DUAA3QWMCELA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQXDQQ#issuecomment-560034242, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGXENGRRR7O4C2WB465JWLQWMCELANCNFSM4I2TLTFA .
Awesome!
On Sun, Dec 1, 2019, 11:41 AM Holly Casaletto notifications@github.com wrote:
Changed to not show until someone clicks next.
On Sat, Nov 30, 2019 at 4:43 PM cgilliard notifications@github.com wrote:
Is there a way to make it not appear until you click the next button? I'm thinking it makes the url look a little populated if it's always there.
On Sat, Nov 30, 2019 at 4:39 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Yes, it worked thanks!
On Sat, Nov 30, 2019 at 3:09 PM Holly Casaletto < notifications@github.com> wrote:
Fixed and re-deployed on AWS 34.238.121.224. Please check.
Thanks, Holly
On Fri, Nov 29, 2019 at 4:57 AM cgilliard notifications@github.com wrote:
Just realized that if you were to email out a page for instance http://34.238.121.224:8080/#r20, if you got the email an hour later, it would have completely different blocks. I think we need to target off of block height instead of last 10 or 20.
On Thu, Nov 28, 2019 at 4:16 PM Christopher Gilliard < christopher.gilliard@gmail.com> wrote:
Looks good. Thanks!
On Thu, Nov 28, 2019 at 1:33 PM Holly Casaletto < notifications@github.com> wrote:
On Thu, Nov 28, 2019 at 12:12 PM cgilliard < notifications@github.com
wrote:
oh ok great. What's the link?
On Thu, Nov 28, 2019 at 12:03 PM Holly Casaletto < notifications@github.com
wrote:
No, I fixed this deep link issue. Now there is a link. It's redeployed on AWS. Please let me know if it looks good to you.
Thanks, Holly
On Thu, Nov 28, 2019 at 11:55 AM cgilliard < notifications@github.com> wrote:
I think your last comment is about this issue: #10 https://github.com/mwcproject/mwcbuildpipeline/issues/10
Right?
This issue relates to clicking the "next" button on the main page. When you do that, there's no anchor. So I can't send anyone a link to that page.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENAYUAF33RWCNA2WEKLQWAOZ5ANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVNZWD3647WR24LHYYCTQWAP2ZANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENCRFVKHRBSVDQLM55TQWAQ2DANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVN3QGVK2SW373LD5LDLQWA2L7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ALGXENHHP5FPB7KCF5IN3TLQWEGUPANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <
,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABXFVN7KLTKFPZU6ZPVOGYTQWLXA7ANCNFSM4I2TLTFA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ALGXENBHF6BEVMVKZ2DUAA3QWMCELA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQXDQQ#issuecomment-560034242 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALGXENGRRR7O4C2WB465JWLQWMCELANCNFSM4I2TLTFA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwcproject/mwcbuildpipeline/issues/16?email_source=notifications&email_token=ABXFVN3CHVAMMTYQB6GJUWTQWQHOTA5CNFSM4I2TLTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRTNQY#issuecomment-560150211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXFVN2UQ2ZUEEEOS73UMRLQWQHOTANCNFSM4I2TLTFA .
If you click on "Next" from the mainpage, you cannot see the url in the browser. There should be a way to get to it.