search

mwcraig / ipyevents

A custom widget for returning mouse and keyboard events to Python. Documentation:
https://ipyevents.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
115 stars 27 forks source link

Refactor into two listeners, Mouse and Keyboard #10

Closed mwcraig closed 3 years ago

mwcraig commented 6 years ago

Argument for: Simplifies some of the logic in DOMListener if mouse and keyboard handling are separate.

Argument against: There is much in common between the two cases (can be addressed by subclassing).

See https://github.com/jupyter-widgets/ipywidgets/pull/1727#pullrequestreview-69144328

mwcraig commented 3 years ago

Current structure seems to work, so won't change it