mwcraig / ipyevents

A custom widget for returning mouse and keyboard events to Python. Documentation:
https://ipyevents.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
112 stars 27 forks source link

Specify latest frontend version for jlab, embedding & voila #28

Closed SylvainCorlay closed 5 years ago

SylvainCorlay commented 5 years ago

This was causing the older version to be loaded, and 1.2.0 is not available on npmjs.

cf https://github.com/QuantStack/voila/issues/11

mwcraig commented 5 years ago

@SylvainCorlay -- just to make sure I understand, the extension spec version needs to be the same as the npm version? My understanding had been that the extension spec version was essentially internal.

SylvainCorlay commented 5 years ago

@SylvainCorlay -- just to make sure I understand, the extension spec version needs to be the same as the npm version?

My understanding had been that the extension spec version was essentially internal.

Hey, yes it needs to be the same, or more generally to be a semver range that includes the actual npm version. Typically ^VERSION.

This is used in two ways:

It is generally not used in the case of the classic notebook.

mwcraig commented 5 years ago

OK, in that case I'll increment the version in all the places and do a new release. Thanks for the explanation, additional commits incoming to your PR in a few minutes...

mwcraig commented 5 years ago

Thanks, @SylvainCorlay!