search

mwcraig / ipyevents

A custom widget for returning mouse and keyboard events to Python. Documentation:
https://ipyevents.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
112 stars 27 forks source link

Changing source of an `Event` does not remove listeners from the old source #32

Closed mwcraig closed 5 years ago

mwcraig commented 5 years ago

It appears that when source changes nothing is done to clean up the old source, so its listeners remain active (at least on the JS side).

mwcraig commented 5 years ago

Oops, this isn't actually an issue...

mwcraig commented 5 years ago

Reopening, because the listeners do stay around. They don't have any apparent effect because backbone is told to stop listening, but the JS listeners may as well be removed.

mwcraig commented 5 years ago

Might be time to step away from the keyboard, because it turns out that, yes, the listeners are removed....