Closed mweastwood closed 7 years ago
Merging #26 into master will increase coverage by
0.68%
. The diff coverage is96.62%
.
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 95.73% 96.41% +0.68%
==========================================
Files 6 7 +1
Lines 164 279 +115
==========================================
+ Hits 157 269 +112
- Misses 7 10 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/pixel.jl | 97.95% <100%> (+6.53%) |
:arrow_up: |
src/transforms.jl | 100% <100%> (ø) |
:arrow_up: |
src/projections.jl | 100% <100%> (ø) |
|
src/LibHealpix.jl | 66.66% <66.66%> (-8.34%) |
:arrow_down: |
src/alm.jl | 94.18% <94.18%> (-5.82%) |
:arrow_down: |
src/map.jl | 96.49% <96.49%> (+0.26%) |
:arrow_up: |
src/io.jl | 98.3% <98.3%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 53a6a1a...960b429. Read the comment docs.
Over the last year or so this package has gotten a little stale. I've been somewhat hesitant to keep this package up to date because I'm trying to finish up some work and I didn't want to update my environment until that was done (I'm still using Julia v0.4 in places...). Well, it's still not done, but I've spent some of my free time rewriting this package because I've learned a lot more about how to write Julia code and I was somewhat embarrassed by its current state.
So here it is. I've rewritten almost the entire package to create something that doesn't suck.
Ptr{Void}
because this doesn't play nicely with Julia's GC (fixes #24)Float32
(reading/writing fits files) orFloat64
(spherical harmonic transforms) now work with eitherHealpixMap
has been split intoRingHealpixMap
andNestHealpixMap
. Both of these are subtypes ofAbstractVector
now, andnside
is no longer a type parameterAlm
is now a subtype ofAbstractVector
andlmax
/mmax
are no longer type parameters. (this and the previous point fixes #21 and fixes #25)Alm
object byl
andm
now requires the@lm
macro in order to play nicely with theAbstractVector
interface (see https://discourse.julialang.org/t/custom-indexing-for-an-abstractvector-breaks-display-but-not-show/3813?u=michael_eastwood)Alm
and bothHealpixMap
s implement custom broadcastingQuantumNumberIterator
that allows for easy iterating over values ofl
andm
StaticArrays
for making this easy)BinDeps
There are still a couple todo items before another release can be tagged: