search

mweastwood / TTCal.jl

A calibration routine developed for the OVRO LWA.
http://mweastwood.github.io/TTCal.jl
Other
11 stars 6 forks source link

don't deploy a new version of TTCal until Julia v0.5.1 lands #58

Open mweastwood opened 8 years ago

mweastwood commented 8 years ago

Currently Travis is consistently timing out on the calibration tests because they go >10 min without outputting anything. Notably it is not hanging. If I insert some print statements you can see that it's still running, just incredibly slowly. I feel like I should have noticed this locally though.

I've managed to rule out the latest changes to CasaCore.jl. So there's either something sinister in this commit or something about Julia v0.5 is slowing things down. Inlining changes maybe?

This issue seems relevant: https://github.com/JuliaLang/julia/issues/17476

mweastwood commented 8 years ago

I've discovered an error in type inference but I haven't been able to produce a minimal example. It seems almost impossible to remove blocks of code while maintaining the error.

It shows up here: https://github.com/mweastwood/TTCal.jl/blob/7f71c1c98e9cb382666a85fe571f7f9e64073825/src/calibration.jl#L446

@code_warntype indicates that Nant is being inferred as Any which then means my loop indicies i and j also get the Any type. Adding a type assert doesn't seem to fix the slow down though.

mweastwood commented 8 years ago

omfg so much time wasted. this is fixed on master. hopefully whatever the fix was is backported to v0.5.1