mweibel / connect-session-sequelize

Sequelize SessionStore for Express/Connect
211 stars 71 forks source link

Typescript error: Non-abstract class 'SequelizeStore' does not implement inherited abstract member 'destroy' from class 'Store'. #125

Closed djake closed 3 years ago

djake commented 3 years ago

Hello,

Thanks for this module which saved me some time in development.

I'm converting a project to typescript and got the following error:

$ npx tsc --project tsconfig.json     
node_modules/connect-session-sequelize/index.d.ts:22:15 - error TS2515: Non-abstract class 'SequelizeStore' does not implement inherited abstract member 'destroy' from class 'Store'.

22 declare class SequelizeStore extends Store {
                 ~~~~~~~~~~~~~~

node_modules/connect-session-sequelize/index.d.ts:22:15 - error TS2515: Non-abstract class 'SequelizeStore' does not implement inherited abstract member 'get' from class 'Store'.

22 declare class SequelizeStore extends Store {
                 ~~~~~~~~~~~~~~

node_modules/connect-session-sequelize/index.d.ts:22:15 - error TS2515: Non-abstract class 'SequelizeStore' does not implement inherited abstract member 'set' from class 'Store'.

22 declare class SequelizeStore extends Store {
                 ~~~~~~~~~~~~~~

Found 3 errors.

For reference, my tsconfig:

{
    "include": [
        "src/**/*",
    ],
    "exclude": ["node_modules", "public"],
    "compilerOptions": {
        "allowJs": true,
        "jsx": "react-jsx",
        "outDir": "public",
        "target": "ES2020",
        "module": "CommonJS",
        "moduleResolution": "node",
        "allowSyntheticDefaultImports": true,
        "esModuleInterop": true,
        "isolatedModules": true,
        "resolveJsonModule": true,
        "incremental": true,
        "tsBuildInfoFile": ".tsbuildinfo"
    }
}
AlanMorel commented 3 years ago

Let me know if this works for you Jake: https://github.com/mweibel/connect-session-sequelize/pull/126

djake commented 3 years ago

Sure does! Thank you!

AlanMorel commented 3 years ago

Great, thanks for confirming!