search

mweibel / connect-session-sequelize

Sequelize SessionStore for Express/Connect
212 stars 72 forks source link

add option tableName and modelKey (string) for SequelizeStore #93

Closed durek1337 closed 4 years ago

durek1337 commented 4 years ago

Please change documentation.

It should now be possible to use:

var sessionStore = new SequelizeStore({db : sequelize, defaultTableName : "session"}) sessionStore.sync()

mweibel commented 4 years ago

Please change documentation.

Please change it yourself :) Amend README in this PR.

mweibel commented 4 years ago

Please fix the code style as well: https://travis-ci.org/mweibel/connect-session-sequelize/jobs/639709785

Run node_modules/.bin/standard --fix

durek1337 commented 4 years ago

Thanks for watching. I will fix all that today evening or the next days. I was a little bit tired when I was doing this.

mweibel commented 4 years ago

Looks good so far. Not sure if the default prefix is needed for those options? Just two things needed now:

durek1337 commented 4 years ago

Yes, I guess the prefix could be removed. I will do this in my next push. I'm not experienced with collaborating in open source projects. I thought I could add this quicker. The linter issues should be no problem but I have to look for the tests first. Please give me some time to do it right.

mweibel commented 4 years ago

Sure, no worries. Let me know if you have any questions :)

durek1337 commented 4 years ago

Thanks for your offer for helping me but I guess I understand the use of it now :) I guess everything should be fine now

durek1337 commented 4 years ago

Hello, is everything fine with my last push? If yes, could you merge it? I would like to use the npm-repo instead of my own local :)

mweibel commented 4 years ago

Yes indeed. Thanks a lot! Will release a new version soon.

mweibel commented 4 years ago

Released version 6.1.0 with this feature.