mweibel / lcov-result-merger

Merges multiple lcov results into one
MIT License
100 stars 22 forks source link

Don't limit support for node >9 #38

Closed ritave closed 6 years ago

ritave commented 6 years ago

Node is at v10 now.

Lcov-result-merger blocks the whole build due to it's limitation in package.json to node versions <= 9.

I imagine this tool still works with the newest version of node, please remove the artificial limit

mweibel commented 6 years ago

You’re more than welcome to submit a pr.

On 23 May 2018, at 18:04, Olaf Tomalka notifications@github.com wrote:

Node is at v10 now.

Lcov-result-merger blocks the whole build due to it's limitation in package.json to node versions <= 9.

I imagine this tool still works with the newest version of node, please remove the artificial limit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mweibel commented 6 years ago

I added a PR for this, once travis says that's ok I'll publish a new release.

@ritave I'm doing this project in my free time. The issue you opened is valid, but I'd welcome a friendlier tone the next time. Also during the time you've written that issue you could already have opened a PR changing the requirements which would have helped everyone. Please consider this the next time, thanks.

ritave commented 6 years ago

@mweibel My bad, it was not my intention to make it sound harsh. I had some time to work on this today - seems we've both added a PR. Additionally found a bug due to carriage returns.

mweibel commented 6 years ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mweibel commented 6 years ago

@ritave thanks! I merged yours now, as mine is failing because there's an issue with node 10.2.0 atm. As you've seen, this and some other fixes should be released as version 3 now. 👍

mweibel commented 6 years ago

:tada: This issue has been resolved in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: