Replace vinyl-fs with glob-stream

mweibel / lcov-result-merger

Merges multiple lcov results into one

MIT License

102 stars 22 forks source link

Replace vinyl-fs with glob-stream #48

Closed hugobessa closed 2 years ago

hugobessa commented 2 years ago

Vinyl-fs didn't have any updates since a few years ago and the version of glob-parent they use has vulnerabilities reported by DependaBot. So I'd like to propose replacing it with glob-stream directly.

mdeanjones commented 2 years ago

I am certainly 100% on board with this. There is a lot of dependency housekeeping to be looked at.

mdeanjones commented 2 years ago

Make sure that your replacement includes relevant tests.

https://github.com/mweibel/lcov-result-merger/blob/b665a25087f2e3bbae241012ae9db57cad437d71/test/lcov-result-merger-spec.js#L3

hugobessa commented 2 years ago

The tests were all failing and I preferred to go in another direction: replacing vinyl-fs with fast-glob instead. I'm opening another PR for that (and the tests are already fixed there too 🙌)