Replace vinyl fs by fast glob

mweibel / lcov-result-merger

Merges multiple lcov results into one

MIT License

102 stars 22 forks source link

Replace vinyl fs by fast glob #50

Closed hugobessa closed 2 years ago

hugobessa commented 2 years ago

Vinyl-fs didn't have any updates since a few years ago and the version of glob-parent they use has vulnerabilities reported by DependaBot. So I'd like to propose replacing it with fast-glob instead.

hugobessa commented 2 years ago

@mdeanjones the tests are passing locally, but apparently, they're all failing in TravisCI. Do you have any hint on what may be going on?

hugobessa commented 2 years ago

Actually, it is failing on Github Actions, not Travis. I've got confused because I saw the config file for Travis. I suspect this is related to the node engine.

hugobessa commented 2 years ago

I took the liberty, to limit the node engines to >=14. Feel free to let me know if that's not reasonable. The tests are passing on CI now.

coveralls commented 2 years ago

Coverage remained the same at 100.0% when pulling e8e811e70f7eb5aa76cee969fb7da60bd07f2df3 on plusplusco:replace-vinyl-fs-by-fast-glob into 2046cef6f78c55528754d1b046aabfa7ff320b4a on mweibel:master.

mdeanjones commented 2 years ago

Node 14 is the current maintenance, with 16 being active. Provided its a major version bump I can't find too much justification to not modernize.