search

mweimerskirch / smarty_dsmr_proxy

This project is abandoned. I recommend using https://www.zuidwijk.com/product/slimmelezer-plus/
MIT License
20 stars 13 forks source link

refs #7 - add initial mqtt support #10

Closed haklein closed 2 years ago

haklein commented 3 years ago

refs #7 - This is not tested a lot, so you might refrain from instant merging

mweimerskirch commented 3 years ago

Code looks good. I added two comments with ideas that I think would be important (additional command line arguments to enable this as well as command line arguments for MQTT port, username and password). Let me know if you prefer that I do the changes after merging.

I also changed the target of the pull request from master to develop (I created that branch just now, it didn't exist before), so we can keep it on a separate branch until it's ready.

Thank you for your contribution.

haklein commented 3 years ago

feel free to modify according to your needs :-)

mweimerskirch commented 2 years ago

I still don't have enough time to work on this unfortunately. Merging it as is, as everything is optional. If somebody needs the additional parameters (port, username, password) they can add them later. Thank you for your contribution.