search

mweinelt / kea-exporter

Export Kea Metrics in the Prometheus Exposition Format
MIT License
33 stars 17 forks source link

packet statistics should use a counter instead of gauge #52

Open M0NsTeRRR opened 5 months ago

M0NsTeRRR commented 5 months ago

Packet statistics currently use a gauge, but they should use a counter instead. Kea only increments values for packet statistics since there's a command to reset them to 0.

Kea reset command Prometheus documentation

Qwiko commented 5 months ago

Is there other metrics that also could be represented by a counter? Maybe there are some other metrics that could benefit using a counter instead.

@M0NsTeRRR do you want to work on this and provide some code?

M0NsTeRRR commented 5 months ago

I let you review my linked PR @Qwiko :)