mwelz / GenericML

R implementation of Generic Machine Learning Inference (Chernozhukov, Demirer, Duflo and Fernández-Val, 2020).
GNU General Public License v3.0
60 stars 14 forks source link

Methods update #24

Closed mwelz closed 2 years ago

mwelz commented 2 years ago
aalfons commented 2 years ago

Thanks, in general it looks very nice and the class structure is good, but there are some details that need attention.

Naming can be improved:

In the documentation, not all instances of class names are put in quotation marks, and not all function names are followed by parentheses:

These are details, but attention to those details matters if we want people to be confident about using the package.

mwelz commented 2 years ago

Thank you for your comments, @aalfons! I have implemented your suggested changes; I ultimately went for "CI lower etc. as printed name of the confidence bounds.