search

mwerle / OrbitalMaterialScience

KSP mod that adds new ways to get science from space stations.
GNU General Public License v3.0
5 stars 4 forks source link

Unable to generate contracts #11

Closed tim-white87 closed 7 years ago

tim-white87 commented 7 years ago

Hey Mwerle,

Much thanks for this, it is an awesome addition. Basically with the latest version, I am unable to generate new contracts (and none get auto generated). I confirmed it was the release by downloading https://github.com/mwerle/OrbitalMaterialScience/releases/tag/0.7a0-mw7-KSP120_pre and then generating a new contract via the cheat window. In the earlier version, I was able to generate contracts, however the latest no longer able to create them. Note, I had to roll back to 1.2.2 in KSP for this to work as well, it doesn't appear compatible with 1.3 yet. I am downloading the code to see if I can fix the issue on my own. If you are aware of a quick fix, please let me know and I will hold off on trying to fix it.

Thanks! Tim

tim-white87 commented 7 years ago

It looks like its likely this: https://github.com/mwerle/OrbitalMaterialScience/commit/b391eb59a3dd021ebb313a6439a13b9a3f33dd13

mwerle commented 7 years ago

Hi Tim,

Thanks I'm partway through updating for 1.3 - fixing GUI click-through etc.

I'll take a look at why contracts aren't working.

Unfortunately don't have much time but will try to make a point release soon.

mwerle commented 7 years ago

Contract generation had changed somewhat in 1.3; fixed in f60b2b78956dec38dd46b260aba427839ff27aa3

mwerle commented 7 years ago

Hopefully fixed in 0.7a0-mw8.

tim-white87 commented 7 years ago

Thanks for the quick fix, I will update KSP and give it a shot this evening.