search

mweststrate / relative-deps

Installs local dependencies for optimal developer experience
MIT License
429 stars 32 forks source link

Relative deps configuration as a separated file #30

Open dvh91 opened 4 years ago

dvh91 commented 4 years ago

First off, it's a great and useful library! I'm using it and enjoying every minute.

I think it could be better to hold the relative deps config in a different file which will be possible to add to .gitignore rather than holding it in package.json.

When working with multiple packages with few devs working on the same project, sometimes not everyone has the same repos structure locally and it's possible for some people to only have a subset of the relative deps and not all of them (which now fails the process when the first relative dep is not found).

mweststrate commented 4 years ago

Makes sense! Feel free to create a PR that supports that pattern. Please do make sure the old approach works as well :)

On Fri, Jul 10, 2020 at 9:27 AM Dvir Hazout notifications@github.com wrote:

First off, it's a great and useful library! I'm using it and enjoying every minute.

I think it could be better to hold the relative deps config in a different file which will be possible to add to .gitignore rather than holding it in package.json.

When working with multiple packages with few devs working on the same project, sometimes not everyone has the same repos structure locally and it's possible for some people to only have a subset of the relative deps and not all of them (which now fails the process when the first relative dep is not found).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mweststrate/relative-deps/issues/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBCMZST3UF6F5TPSU4TR23GFHANCNFSM4OWLXOIQ .