search

mwganson / ThreadProfile

Create 2d thread profile for sweeping along helix in Part or Part Design workbenches
GNU Lesser General Public License v2.1
40 stars 8 forks source link

Can not change Height? #56

Open MarioElHazard opened 1 year ago

MarioElHazard commented 1 year ago

If the Height parameter in VThreadProfile is changed the Additive Pipe breaks. In report view: "Recompute failed! Please check report view." If a new VThreadProfile is started any Height can be given but not changed after the AdditivePipe is made.

FreeCAD 0.20 29177 - 2022/06/13 ThreadProfile version 1,85

image

mwganson commented 1 year ago

Thanks for the report. FreeCAD has changed by adding a new property to the Helix object called SegmentLength. If set to 0 (default) you no longer get segmented helices, which is good, but which also breaks the workbench. I have attempted to resolve this while also maintaining compatibility with earlier versions. New version is 1.86. Please update and test the new version and report back here.

MarioElHazard commented 1 year ago

Thanks for your quick response. Updated to 1.86. Now height can be changed. But if the pitch is changed the height of the helix changes in the model (VThreadProfile.ThreadCount * VThreadProfile.Pitch). However, the number of height in Thread Profile panel stays the same. Also the ThreadCount does not update when the pitch is changed.

image

mwganson commented 1 year ago

New version 1.87. Please update and test again. Thanks.

Edit: Please also check that existing models are not broken.

MarioElHazard commented 1 year ago

Works fine. Thank you!