add 266 USA airports - Githubissues

mwgg / Airports

A JSON database of 28k+ airports with ICAO/IATA codes, names, cities, two-letter country identifiers, elevation, latitude & longitude, and a timezone identifier

MIT License

488 stars 174 forks source link

add 266 USA airports #141

Closed maidough closed 2 weeks ago

eatdostacos commented 2 weeks ago

I noticed that the latitude and longitude for the new airports are strings which doesn't follow the convention in the rest of the file. Thanks for all the additions!

maidough commented 2 weeks ago

oops, that was a mistake. fixed

mwgg commented 2 weeks ago

Thanks, missed that too!

mwgg commented 2 weeks ago

Added that to the github actions, it will now automatically check it on every PR.

alexander-san commented 2 weeks ago

Just want to chime in here @mwgg :

Can the key for an airport be anything? Because I was under the impression that until now we ensured the airport key is of length = 4. In the case of non-ICAO airports (e.g. X05 - great airport btw., we pre-fixed this with 'K' to indicate the general location of the airport (e.g. USA)
I am also good with changing away from the airport key having to be 4, however, the airports can most certainly not have a 3 digit identifier. This is wrong and I am sure that there are applications out there where parsing this could result in problems.

IMO, while not correct, I like the idea of prefixing it with a 'K'. However, we must certainly address this from a consistency perspective because right now we do both...

mwgg commented 2 weeks ago

The key should match whatever is in the icao field. Many years ago, when it was a MySQL table in a project of mine, that's how it was exported for this repo, and that's what it says in the README. Obviously it's not always ICAO, sometimes it's the FAA identifier.

I do see that we have FAA identifiers both ways. About 200 entries with the 3-letter identifier and way more with the K prefix. For the sake of consistency I agree that we should have it the same way, and the K prefix is a common way of denoting FAA identifiers.

I've changed the existing 3-letter entries, and added a check to be performed on each PR to ensure it's always 4, as well as verifying the key matches the icao field.

https://github.com/mwgg/Airports/pull/143