Fanart and GUI property for fanart page title

[GoogleCodeExporter]

What steps will reproduce the problem?
#TVSeries.Fanart.PageTitle
If you open up a fanart chooser few times after and before loading fanart
in the plugin, sometimes after playing a file, somewhere along the way
property value will become invalid ("-.PageTitle" or
"C:\...snip....PageTitle"). I've connected this with the MyTrailers plugin
being in plugins directory and enabled (defect behavior) or not (working
ok). Have no idea why are they connected.

What version of the product are you using? On what operating system?
MP SVN, TVSeries SVN, Blue3Wide / Black&White skins (both not working OK if
MyTrailers enabled).

Now i noticed that using B3W some fanart won't load if MyTrailers is
enabled.. Weird stuff.. When MyTrailers is removed, everything's fine..

Original issue reported on code.google.com by mitja.skuver on 27 Mar 2009 at 12:30

[GoogleCodeExporter]

I also have MyTrailers and havent seen anything like you describe.

I also got your skin from googlecode and had no problem with it. Are you not 
seeing
anything strange in the error.log or mediaportal.log?

Original comment by damien.haynes@gmail.com on 27 Mar 2009 at 5:02

[GoogleCodeExporter]

i've even made few videos so you don't think i'm crazy :)
nothing in logs :(

and it all happens only if MyTrailers.dll is in plugins/Window.. if i remove 
it, back
to normal.. what version of MyTrailers are you using?

Original comment by mitja.skuver on 27 Mar 2009 at 8:21

[GoogleCodeExporter]

I believe you, I just dont know what to do to help you.

Im using MyTrailers v2.0.2.31. I think that is the most recent.

Have you tried disabling some other plugins...maybe its not just mytrailers?

Its as if the property #TVSeries.FanArt is being evaluated instead of
#TVSeries.Fanart.PageTitle. I have no idea why this would be different on your 
system
though.

Here is a test dll, I create 3 different properties for the same thing.

http://www.2shared.com/file/5189448/924a2284/MP-TVSeries.html

#TVSeries.Fanart.PageTitle (current one)
#TVSeries.FanArt.PageTitle
#TVSeries.FanartPageTitle

Original comment by damien.haynes@gmail.com on 27 Mar 2009 at 11:19

[GoogleCodeExporter]

so we both have same version of MyTrailers.. what about MP version? Latest SVN 
(22029)? 

i tried disabling everything, then by elimination noticed that problem is
MyTrailers.dll. it's clear and i did it hundreds of times: MyTrailers in
plugins/Windows, no go; remove it, working!

looks like indeed, #TVSeries.Fanart (lowercase a) gets parsed first (the fanart
property used in TVSeries.xml)

i'll try this test dll as soon as my htpc is freed :)

could you also do a test version where you completely disable
#TVSeries.Fanart.PageTitle (current one)? and use just two new ones..

thanks for all your help!

Original comment by mitja.skuver on 27 Mar 2009 at 11:51

[GoogleCodeExporter]

Here you go, this has the original disabled:
http://www.2shared.com/file/5189929/bbcf26c7/MP-TVSeries.html

Im using latest SVN as well 22nd March

Original comment by damien.haynes@gmail.com on 27 Mar 2009 at 12:39

[GoogleCodeExporter]

MyTrailers.dll in plugins/Windows:
#TVSeries.Fanart.PageTitle (current one) = "-.PageTitle" NOK
#TVSeries.FanArt.PageTitle = "Fanart" OK
#TVSeries.FanartPageTitle = "-PageTitle NOK

MyTrailers.dll deleted from plugins/Windows:
#TVSeries.Fanart.PageTitle (current one) = "Fanart" OK
#TVSeries.FanArt.PageTitle = "Fanart" OK
#TVSeries.FanartPageTitle = "-PageTitle NOK

tested 3 times in a row:
With MyTrailers.dll
Without MyTrailers.dll

With MyTrailers.dll
Without MyTrailers.dll

With MyTrailers.dll
Without MyTrailers.dll

:(

Original comment by mitja.skuver on 27 Mar 2009 at 12:40

[GoogleCodeExporter]

some findings

on the same way as before sometimes #TVSeries.Fanart2 property doesn't get 
parsed
right, it's parsed with #TVSeries.Fanart property value plus '2' (string). as 
this
isn't valid image gui will probably just show the default fanart (if set)..

take a look at:
http://www.google.com/codesearch/p?hl=en#md8pL4QPwK4/trunk/mediaportal/Core/guil
ib/PropertyManager.cs&q=GUIProperty

public static string Parse(string line)

function at the end..

the way i see it, no two GUI properties should be set with one being subset of
another.. and all gui properties in mp are set that way..

so i propose for you to use (or add) #TVSeries.Fanart.1 & #TVSeries.Fanart.2 
instead
of current ones and also #TVSeries.FanArt.PageTitle (with 'FanArt') just to be
consistant with other properties in fanart chooser..

let me know what you think..

Original comment by mitja.skuver on 28 Mar 2009 at 3:42

[GoogleCodeExporter]

Makes sense, I will make the proposed changes.

Original comment by damien.haynes@gmail.com on 28 Mar 2009 at 10:01

• Changed state: Accepted
• Added labels: Milestone-2.2

[GoogleCodeExporter]

Original comment by damien.haynes@gmail.com on 28 Mar 2009 at 10:01

[GoogleCodeExporter]

Original comment by damien.haynes@gmail.com on 28 Mar 2009 at 10:23

• Changed state: Started

[GoogleCodeExporter]

Done r572

Original comment by damien.haynes@gmail.com on 28 Mar 2009 at 10:42

• Changed state: Fixed

[GoogleCodeExporter]

thanks! i think this should work now.. 

if possible, new test version would be nice :) or maybe update the main one?

Original comment by mitja.skuver on 28 Mar 2009 at 11:47

[GoogleCodeExporter]

Here you go: http://www.2shared.com/file/5201891/24720c89/MP-TVSeries.html

Original comment by damien.haynes@gmail.com on 28 Mar 2009 at 11:51