mwheelerjr / mptvseries

Automatically exported from code.google.com/p/mptvseries
0 stars 0 forks source link

Plugin needs to give-up on Importing if there is a large number of consecutive failures #259

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Plugin needs to give-up on Importing if there is a large number of
consecutive failures.

If the API is available but for some reason the banners fail to download
(like it is now!) then we need to give up. Maybe after 10 failed downloads
is reached.

Otherwise it will take forever to finish an import.

Original issue reported on code.google.com by damien.haynes@gmail.com on 15 Aug 2009 at 9:22

GoogleCodeExporter commented 9 years ago

Original comment by damien.haynes@gmail.com on 22 Oct 2009 at 10:39

GoogleCodeExporter commented 9 years ago
i also noticed similar behaviour for ratings, tvdb was (partially) playing up 
and each series ratings had about a 20 second timeout, total import time was 
around 30 mins in this scenario, usually 2-3mins.

Original comment by connect...@gmail.com on 2 May 2011 at 9:53

GoogleCodeExporter commented 9 years ago
Yeah, we just need to count maybe 3 timeouts and then abort importer.

Original comment by damien.haynes@gmail.com on 2 May 2011 at 10:05

GoogleCodeExporter commented 9 years ago
I have added an option cMaxConsecutiveDownloadErrors.
When Banner Downloads reach cMaxConsecutiveDownloadErrors value of failed 
downloads, it exits further downloads.

It is included in patch:
http://forum.team-mediaportal.com/threads/patch-for-mp-tvseries-issue-541-263-re
-downloading-of-missing-corrupt-artwork.113224/#post-924110

It would need UI option to set cMaxConsecutiveDownloadErrors in the database.

Took only artwork into account, not ratings.

Original comment by michel.zehnder on 17 Oct 2012 at 5:57

GoogleCodeExporter commented 9 years ago
Thanks michel, will take a look at this for next release.

Original comment by damien.haynes@gmail.com on 19 Oct 2012 at 11:53

GoogleCodeExporter commented 9 years ago
Thanks, done r1986.

I added configuration to configure cMaxConsecutiveDownloadErrors.

Original comment by damien.haynes@gmail.com on 15 Dec 2012 at 7:37