search

mwheelerjr / mptvseries

Automatically exported from code.google.com/p/mptvseries
0 stars 0 forks source link

Check if posters/banners exists on import #541

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Remove ProgramData\Team MediaPortal\MediaPortal\thumbs\MPTVSeriesBanners
2. Do a full import
3. Posters/banners are not redownloaded

What is the expected output? What do you see instead?
No posters/banners are downloaded and nothing is showed.

What version of MP-TVSeries and MediaPortal are you using?
MP-TVSeries Version: v3.0.0.1389
Configuration v1.1.6.27602 

What Skin are you using?
Maya svn

On what operating system?
Windows 7 ( Service Pack 1 ) [6.1.7601.65536]

Please provide any additional information below e.g. Logs & Pictures.

So mptvseries does still thinks they exists and does not download new onces as 
the reference to them are kept
Logs:
00000001 - 27-02-2011 13:19:51 - Image does not exist: C:\ProgramData\Team 
MediaPortal\MediaPortal\Thumbs\MPTVSeriesBanners\5ive Days to 
Midnight\-langen-graphical/79546-g.jpg - C:\ProgramData\Team 
MediaPortal\MediaPortal\Thumbs\MPTVSeriesBanners\5ive Days to 
Midnight\-langen-graphical/79546-g.jpg

So it should check when it tried to do an import.

I'm pretty sure this already is the case for fanart and episodes as these show 
fine. But please check that as well :)

Original issue reported on code.google.com by Steffa...@gmail.com on 27 Feb 2011 at 12:30

GoogleCodeExporter commented 9 years ago 
Can you check your download limits...its probably because its limited to get 
only the top 3 artwork and ignored the rest. Although it should clear any 
reference to art that does not exist.

Im pretty sure we already do a check if the file can load, and if not download 
it. Will double check.

Original comment by damien.haynes@gmail.com on 27 Feb 2011 at 10:48

GoogleCodeExporter commented 9 years ago 
I actually tried to change it to 10, but it doesn't clear the reference.

Original comment by Steffa...@gmail.com on 27 Feb 2011 at 10:53

GoogleCodeExporter commented 9 years ago 
Will try reproduce this today and let you the status.

Original comment by damien.haynes@gmail.com on 2 Mar 2011 at 8:57

GoogleCodeExporter commented 9 years ago 
Any progress on this?

version 3.3.1.1954 (mp 1.2.3.0)
Still has the same issues

Issue  263 is probably fixed with the same solution

Original comment by GeePh...@gmail.com on 30 Jun 2012 at 1:08

GoogleCodeExporter commented 9 years ago 
My current workaround:
SQLitebrowser, open tvseriesdatabase4.db3

execute the following 2 SQL statements:
UPDATE `Online_Series` SET `BannerFileNames` = ''
UPDATE `Online_Series` SET `PosterFileNames` = ''

to clean the database and after that start the import wizard again

Then all posters and banners get re-downloaded so its a little overkill but it 
gets the job done

Original comment by GeePh...@gmail.com on 30 Jun 2012 at 2:11

GoogleCodeExporter commented 9 years ago 
I have created a patch which does the following:

This patch removes missing/corrupt banners/posters from the MP-TVSeries 
Database. This re-downloads missing artwork.

 The patch also checks if newly downloaded artwork is available and not corrupt before inserting it into the database.

I cannot upload here due to quota exceeded, I have created a forum thread in 
MePo Forums:

http://forum.team-mediaportal.com/threads/patch-for-mp-tvseries-issue-541-263-re
-downloading-of-missing-corrupt-artwork.113224/

Would be great if you could give it a try, and report back if it works.
The project owners then hopefully include it... :)

Original comment by michel.zehnder on 17 Oct 2012 at 4:58

GoogleCodeExporter commented 9 years ago 
Thanks michel, will take a look at this for next release.

Original comment by damien.haynes@gmail.com on 19 Oct 2012 at 11:54

GoogleCodeExporter commented 9 years ago 
dumb question, how do I run this .patch file?
Thanks,
Jason Pichie

Original comment by JPic...@gmail.com on 12 Nov 2012 at 4:23

GoogleCodeExporter commented 9 years ago 
There is a major bug in the BannerList and PosterList {set} properties. 

This is the first time they have been used like you have in the CheckBanners() 
method. What it does is creates an incorrectly joined string of 
posters/banners. What it should do is create a pipe separated string.

I will fix this up and then commit your patch.

Original comment by damien.haynes@gmail.com on 15 Dec 2012 at 3:49

GoogleCodeExporter commented 9 years ago 
Fixed properties in r1984.

Original comment by damien.haynes@gmail.com on 15 Dec 2012 at 5:04

GoogleCodeExporter commented 9 years ago 
Thanks, done r1986.

Also added a check to add missing selected artwork to list of available 
artwork. I think this was due to bug mentioned in comment 9. This event 
probably will never occur again but doesnt hurt to have it in place anyway.

Original comment by damien.haynes@gmail.com on 15 Dec 2012 at 7:42