mwheelerjr / mptvseries

Automatically exported from code.google.com/p/mptvseries
0 stars 0 forks source link

Step 2 of Import Wizard: UpdateUserRatings if no Mirrors available causes exception #635

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Start an import wizard for a series that has no online mirror available
2. After the parsing, hit "NEXT" and go to step 2
3. Here you have the series with "No Results found" in "Matched Online Series"
4. Hit "NEXT"

What is the expected output? What do you see instead?
The import procedure starts, but then it suddenly aborts, leaving the import 
incompleted.

What version of MP-TVSeries and MediaPortal are you using?
Mediaportal 1.2.3 and MP-TVSeries-3.3.0.1943

What Skin are you using?
StreamedMP

On what operating system?
Windows 7

Please provide any additional information below e.g. Logs & Pictures.
I downloaded sources and attached a debugger to the DLL. The problem occurs 
here, in "OnlineParse.cs"

                    case ParsingAction.UpdateUserRatings:
                        if (DBOption.GetOptions(DBOption.cOnlineParseEnabled) == 1)
                            UpdateOnlineMirror();
                        if (DBOnlineMirror.IsMirrorsAvailable)
                            tUserRatings = new BackgroundWorker();
                            UpdateUserRatings(tUserRatings);
                        break;

As DBOnlineMirror.IsMirrorsAvailable is FALSE, tUserRatings is never assigned, 
and then inside UpdateUserRatings there's a NullReferenceException.

I think the error is only that the two instructions must be included in 
parenthesis.

Original issue reported on code.google.com by mfocare1@gmail.com on 29 Apr 2012 at 12:17

GoogleCodeExporter commented 8 years ago
Thanks for debugging, will take a look before next release.

Original comment by damien.haynes@gmail.com on 4 May 2012 at 7:55

GoogleCodeExporter commented 8 years ago
Fixed r1951

Original comment by damien.haynes@gmail.com on 15 May 2012 at 12:08