search

mwheelerjr / mptvseries

Automatically exported from code.google.com/p/mptvseries
0 stars 0 forks source link

Wrong Banner/Show title when importing in MP #648

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Go to the banner view in MP
2. Import new Episodes
3. Watch "empty" banners get added, and all shows having wrong banner/title

What version of MP-TVSeries and MediaPortal are you using?
MP 1.2.3 + MP-TVSeries 3.3.1 / MP 1.3.0 (GIT) + MP-TVSeries 3.3.3

What Skin are you using?
streamed-MP

On what operating system?
Windows 7 + Windows 8

Please provide any additional information below e.g. Logs & Pictures.
http://code.google.com/p/mptvseries/wiki/FAQ#Submitting_Useful_Log_Files

I don't know if this is a tvseries or a skin bug... 
Where can I upload screenshot / logs? (will have to produce logs, have 
screenshot), Google code tells me "Issue attachment storage quota exceeded".

Thanks

Original issue reported on code.google.com by michel.zehnder on 16 Oct 2012 at 4:36

GoogleCodeExporter commented 8 years ago 
I believe I have found the issue in the code. It's an inconsistent 
IndexArgument for the ReportFacadeLoadingProgress method, beween 
ElementForDelayedImgLoading, and the actualy DelayedImgLoading, so the wrong 
element gets updated with the Banner.

Unfortunately, I cannot attach the patch here due to storage quota exceeded... 
I have started a thread on the MP Forum: 
http://forum.team-mediaportal.com/threads/patch-for-mp-tvseries-issue-648-wrong-
banner-show-title-when-importing-in-mp.113206/

Original comment by michel.zehnder on 16 Oct 2012 at 7:55

GoogleCodeExporter commented 8 years ago 
Thanks michel, I will take a look at this for next release.

I probably haven't seen this as I use ListPoster layout.

Original comment by damien.haynes@gmail.com on 19 Oct 2012 at 11:52

GoogleCodeExporter commented 8 years ago 
michel, I havent looked too closely at your patch but I did some testing. It 
seems to have an exception on line 2695 of TVSeriesPlugin.cs:

System.ThrowHelper.ThrowKeyNotFoundException()

See full log attached. It occurs when the facade is refreshed during import.

Original comment by damien.haynes@gmail.com on 20 Oct 2012 at 4:45

Attachments:

GoogleCodeExporter commented 8 years ago 
Damien

I have added a check for existence of the key. 
I also added some logging (debug mode), could you run it again with an import 
in debug mode and attach me the log? I'm interested as to why there is no such 
key.

Thanks

Original comment by michel.z...@quadrotech-it.com on 20 Oct 2012 at 8:38

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi Michel, sorry been a bit busy lately trying to get skins done for MP1.3.

Anyway, I tried reproducing again with latest patch but funny enough I 
couldn't. I will continue to test trying to narrow down cause and keep you 
updated.

Original comment by damien.haynes@gmail.com on 22 Oct 2012 at 10:55

GoogleCodeExporter commented 8 years ago 
Michel, I see why I didnt see error in log this time. The logging you added was 
at the wrong level of the if block. Can try this instead:
http://paste2.org/p/2369712

Original comment by damien.haynes@gmail.com on 23 Oct 2012 at 5:24

GoogleCodeExporter commented 8 years ago 
Not sure if its going to help but I reproduced in this log:

"00000003 - 23/10/2012 4:17:41 PM - DelayedImgLoading: Could not find 
GUIListItem with index: 1"

On screen it just shows a blank banner as would be expected in this case.

Original comment by damien.haynes@gmail.com on 23 Oct 2012 at 5:26

Attachments:

GoogleCodeExporter commented 8 years ago 
Strange, I can't see why that index is not there. It should get created on the 
case BackGroundLoadingArgumentType.ElementForDelayedImgLoading: round.

Anyways, it seems to work from a UI perspective. I added your pastebin to the 
patch, and I keep an eye on the log to maybe find the cause of it.

Original comment by michel.z...@quadrotech-it.com on 25 Oct 2012 at 4:32

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks michel, done r1983.

Guess we will see if anyone else experiences issue with the blank banners. We 
can look into it more later.

Original comment by damien.haynes@gmail.com on 15 Dec 2012 at 12:52