search

mwhittaker / quoracle

A Swiss Army knife for read-write quorum systems
MIT License
84 stars 8 forks source link

Apple M1 support #1

Open heidihoward opened 3 years ago

heidihoward commented 3 years ago

Quoracle does not work out of the box on the new Apple M1s because it depends on numpy which does not have M1 support. After trying various workaround (including running terminal through rosetta), this solution worked for me.

No action needed, I just wanted to document this workaround until numpy is updated.

mwhittaker commented 3 years ago

Oh wow, thanks for figuring this out and finding a solution Heidi! Hopefully numpy gets updated soon.

Outside of some code that makes plots, quoracle only really uses numpy in one spot, so we can probably rewrite the code a little to use pure Python and remove numpy as a dependency entirely. I'll add that to my TODO list :)

mwhittaker commented 3 years ago

In commits 6bb6eb29143827d0db2701426d3a14a2cde69278, 9f0532a7d53f96dc25bdcde9c56d2fea9bfa6f4f, and a4dfc6f7515f332b5eafd32f737778120c822ea0, I removed the dependency on numpy. We still depend on matplotlib, though, and I think matplotlib depends on numpy, so trying to pip install quoracle on an Apple M1 will probably still fail I'm guessing. For that though, I think we just have to wait for things to get fixed upstream :)

heidihoward commented 3 years ago

Agreed, it should just be a matter of time before numpy is updated for M1 :)