urlparse1 maintenance - Githubissues

mwhooker / urlparse2

urlparse for humans

4 stars 1 forks source link

urlparse1 maintenance #3

Open mwhooker opened 10 years ago

mwhooker commented 10 years ago

We include the source from cpython's urlparse module in order to avoid hacking up sys.modules as documented in 4f77827951832ab9149904fef509906174d66a47

I'd like to

[ ] document why we did this
[ ] write a test to prove this works well with urlparse (assuming that's why we did this)
[ ] update urlparse1.py with latest version
[ ] possibly roll this back if at all possible. I want to roll back b/c of code rot

cc @brainsik @glyphobet

glyphobet commented 10 years ago

I have no idea why this was done; best guess was that we were trying not to have urlparse in sys.modules when someone imports urlparse2, but I don't see why that would be a problem.

brainsik commented 10 years ago

So long ago. I don't remember either. Well perhaps you'll run into whatever problem it was we were working around. :-)