search

mwiedemeyer / SPDeployment

SPDeployment is a command line tool to deploy all kind of files to SharePoint / Office 365 and set properties if specified.
MIT License
12 stars 5 forks source link

Add return argument (-r) #1

Closed timschoch closed 8 years ago

timschoch commented 8 years ago

If SPDeployment is used in a grunt task the Console.ReadLine(); at the end of the script prevents SPDeployment from finishing correctly. Any chance you could remove this or make a flag that disables that readline?

timschoch commented 8 years ago

Btw, I'm a front end coder and have never written C# code. So this is just me using Google, StackOverflow and some guessing. Not sure if my code works like this, but you'll get the idea. ;)

mwiedemeyer commented 8 years ago

Hi, thanks for your pull request. I hope its fine for you, that I will not merge it. Instead I updated the code to include Environment.ExitCode to indicate success (0) or failure (which I have defined as 500). On missing or wrong arguments, it will return 400.

See this commit

timschoch commented 8 years ago

Way better! Works perfectly, thanks alot for your quick response!