search

mwilck / Audiveris-flatpak

flatpak for the OMR software Audiveris (www.audiveris.org)
Other
1 stars 0 forks source link

Should we submit the flatpak to flathub soon? #1

Open Altonss opened 2 years ago

mwilck commented 2 years ago

Thanks for the question. My original intention was to submit quickly. But flathub requires a valid license tag. I wasn't certain what to put there, as I'd encountered some license compatibility questions with the various Java packages that audiveris pulls in. I've contacted @hbitteur about that. As soon as this is clarified, we can submit.

Altonss commented 2 years ago

All these licenses seem to be permissive free software licenses that can easily be included in an AGPL licensed project like Audiveris. At least on first look it seems fine ;)

mwilck commented 2 years ago

Check the license of JAI.

hbitteur commented 2 years ago

Today, 2-JUN-2022, via commit 3363fabb900d21b7690cc1b24c775939f8e83bc2 on "development" branch, all remaining Audiveris dependencies on JAI have been removed.

You should now be able to pull and safely proceed with your submission

Thanks for your work /Hervé

mwilck commented 2 years ago

Thanks! I'll probably have to do some work on the flatpak. I'll come back to you guys later.

mwilck commented 2 years ago

@hbitteur, are you planning to release a new version? I'm asking because flathub generally accepts only "stable" releases.

hbitteur commented 2 years ago

@mwilck, you are right of course. Sorry for that.

There is an on going work on optional drum notation. When this is completed, a matter of a few weeks, we will publish a 5.3 release.

mwilck commented 2 years ago

Great. So we'll wait for 5.3. Thanks!

hbitteur commented 2 years ago

Today, 2-JUN-2022, via commit 3363fabb900d21b7690cc1b24c775939f8e83bc2 on "development" branch, all remaining Audiveris dependencies on JAI have been removed.

My mistake! I did remove all Audiveris JAI dependencies, but I forgot the fact that JPodRenderer 5.6 version, which is used to handle PDF files, depends on JAI. See this comment.

The consequence is that, without jai-core, Audiveris does not build. I hadn't observed this problem because JAI was left somewhere in a local cache of mine, But if you try to build Audiveris from scratch, Gradle will quickly complain about a missing jai-core 1.1.3 version...

So I had to re-insert JAI dependency in our build.gradle file, with its impact on license ground.

We now have to wait for issue #540 to get fixed.