search

mwild1 / luadbi

Multi-backend SQL database library for Lua
MIT License
38 stars 14 forks source link

Sync source in repo and in LuaRocks #32

Closed moteus closed 6 years ago

moteus commented 8 years ago

In LuaRocks version 0.5 drivers loaded as dbd.<driver> but in current repo they loaded like dbd<driver>

sparked435 commented 8 years ago

This was me, when I built the original Luarocks modules some time ago. It was partially taste but also it made using the built in Luarocks build system easier.

I would have synced it sooner but doing so will break the Visual Studio project and I have no means of supporting Windows at this time.

fliiiix commented 7 years ago

Is there any progress? Since https://luarocks.org/modules/luarocks/luadbi still points to google code

moteus commented 6 years ago

@sparked435 So you do no decide change source on this repo to use dbd.<driver> like in version 0.5 and use dbd<driver> notation. I think because current release on LuaRocks uses such code it worth also change it in currect repo.

sparked435 commented 6 years ago

This issue is still open because I have not yet made the change. :)

I'm looking into seeing if this will break anything on Windows, which is difficult, as I don't have access to any Windows system for development.

sparked435 commented 6 years ago

Fixed in commit bdaf2445e1a596a87b0775a12c051874a302c9a3

fliiiix commented 6 years ago

Cool 👍 fyi: https://luarocks.org/modules/luarocks/luadbi still points to google code!

sparked435 commented 6 years ago

I'm aware. One thing at a time. :)

Currently gearing up for a release, will fix it all at the same time.