mwild1 / luadbi

Multi-backend SQL database library for Lua
MIT License
41 stars 15 forks source link

Add tag(s) with version numbers #36

Closed mp1409 closed 7 years ago

mp1409 commented 8 years ago

Hi there, we are in the process of pointing the FreeBSD ports collection to this repo as new location for LuaDBI. Currently the LuaDBI version in FreeBSD ports is "0.5". However we noticed that there are no version number tags in this repo.

Of course we could just map some git commit to version 0.5 on our side. But in a couple of months some other distribution might face the same problem. So it would be great if you could tag the appropriate git commit with something like "v0.5". Thanks :-)

References:

moteus commented 8 years ago

Checkout #32 I also wait it for a while :)

mwild1 commented 8 years ago

Hmm, that's weird and frustrating. I used the migration tool that Google provided. I'll see what I can do (but I'll be away the next few days at least, so I probably won't be able to handle it before next week).

mp1409 commented 8 years ago

Hi again, this issue is kind of pressing for FreeBSD, as we are currently not able to install LuaDBI and thus Prosody with Postgres or SQLite due to the lack a valid download location.

However, I was able to download the releases from Google Code via the Internet Archive Wayback Machine and diffed them against this Github repo. The following commits would have to be tagged:

Commit Date According version
23cdfd9cc8fb07fea8a8da0e8a4d51ff53de2d88 2009-02-17 v0.1
298d7f37bf5d38f8107c52ef144265247b0e439c 2009-04-18 v0.2
a664e1a36ea32a74f44e94cbe5435191dc2f53a5 2009-09-01 v0.3
832a21903e45a4c3062a24f1468d58ffa6c10295 2009-09-18 v0.4
58513d50e800f6a4d4e999f9682c747c087eab6f 2010-07-18 v0.5

@mwild1: I would have sent you a pull request, but unfortunately there is no possibility to add tags to pull requests. If there is anything else I could do, please just let me know. If you prefer, I could also migrate the repository to a "luadbi" project on GitHub and add the tags there myself. However, I won't do this without your approval, because I do not consider myself fluent in Lua.

moteus commented 8 years ago

@mp1409 I hope you realize that sources on luarocks server do not match to sources in this repo? So making tags need after do sync. Checkout #32

mp1409 commented 8 years ago

I understand that it is an undesirable situation that the luarocks version does not match this repo. However, my priority is to fix LuaDBI on FreeBSD. And the FreeBSD LuaDBI port depends on the version 0.5 from the original Google Code repo, which exactly matches commit 58513d50e800f6a4d4e999f9682c747c087eab6f, and not the luarocks version. This means syncing to the luarocks version and tagging that as v0.5 might break the build on FreeBSD again...

Anyway, I can only make suggestions, it is upon the Prosody maintainers (i.e. @mwild1) to decide.

fliiiix commented 7 years ago

Is there any chance that we getting that or at least a 0.6 release?

sparked435 commented 7 years ago

Tagged version 0.5 as specified above.

Additionally, 0.6 is released.

fliiiix commented 7 years ago

@sparked435 thank you! I will see if we can update the ports in FreeBSD now.