search

mwild1 / luadbi

Multi-backend SQL database library for Lua
MIT License
38 stars 14 forks source link

Make a new release (0.7) #48

Closed mwild1 closed 5 years ago

mwild1 commented 5 years ago

Hey folks, I think it's time we made a new release. Anyone feel inclined to take this on? If not, I can do it.

Any objections or blockers that anyone is aware of?

sparked435 commented 5 years ago

I think a proper resolution to #44 would be good, but that's also a nice to have and not a requirement.

I may be able to find some time to do a formal release this weekend.

JorjBauer commented 5 years ago

If anyone is addressing #44, then pull request #46 could fit in that paradigm (as both are initialization problems).

I'm not sure what pull request #45 is waiting for - it adds a bit of Oracle functionality in production environments, and I'd like to see that in a release.

kawaii commented 5 years ago

Just giving this a nudge since the current version in Debian 9 repositories has started to cause us some issues on a production server. Seems that at some point a nasty segfault with PostgreSQL databases was fixed and hasn't yet made it into a release in Debian. Would be nice if this could be resolved soon, thanks. :)

linuxmaniac commented 5 years ago

@kawaii I already upload a newer version 0.6 to Debian but it's only available in buster/sid https://tracker.debian.org/pkg/lua-dbi

mwild1 commented 5 years ago

Given the bug-fixes we already have ready, I have tagged v0.7 in the repository.

If there are some ready PRs, all the more reason for a 0.8 soon :)

sparked435 commented 5 years ago

Whoops. I embedded a version number, that's now incorrect in the tag for v0.7: https://github.com/mwild1/luadbi/blob/315a2faebcd117b6747b0898318b365b4749e68e/DBI.lua#L85

No worries though, I actually forgot that was there until the scripts I have for building the release for LuaRocks caught it :)

sparked435 commented 5 years ago

0.7 uploaded to Lua Rocks.

Besides the usual notification email to the Lua-L mailing list, anything else that we need/should do for a release? Or is it time to close this?

mwild1 commented 5 years ago

@sparked435 great, thanks!! Sorry, I missed the version number. Maybe we can tag 0.7.1 with just this fix. I recently had quite some issues debugging a problem with another Lua library and found I wasn't running the version it reported as :) (at least there is no 0.6.1 here).

Maybe we could add a release checklist in a RELEASE.md or something...