search

mwild1 / luadbi

Multi-backend SQL database library for Lua
MIT License
41 stars 14 forks source link

how to build the odbc flavour #69

Open mckaygerhard opened 2 years ago

mckaygerhard commented 2 years ago

after check the source i see that all the modules (mysql, psql, sqlite, etc) has each one a directory, but odbc does not.. also search a little and only found a simple file odbc.lua in another repo..

where to put that file.. what files i need to property build the odbc part?

@mwild1 ?

mwild1 commented 2 years ago

I'm afraid I don't know. I've never built, used or tested the odbc component. If you (or anyone) has issues with it, contributions are welcome :)

sparked435 commented 2 years ago

It's actually a separate project with it's own maintainer: https://github.com/moteus/lua-odbc

ODBC is referenced in DBI.lua because he also provided a shim to make it compatible with the DBI interface: https://github.com/moteus/lua-odbc-dbi

For what it's worth, all of said parts are in Luarocks.

mckaygerhard commented 2 years ago

It's actually a separate project with it's own maintainer: https://github.com/moteus/lua-odbc

umm so this must be available as lua lib to be able to use the odbc module of dbi i guess?

ODBC is referenced in DBI.lua because he also provided a shim to make it compatible with the DBI interface: https://github.com/moteus/lua-odbc-dbi

so the ODBC module inside DBI is just a wrapper for ODBC lua lib separate project?

For what it's worth, all of said parts are in Luarocks.

if both prevouos are true then i guess:

1) put the luadbi-odbc-scm-0.rockspec inside the root of the luadbi sources.. 2) put the odbc.lua file inside the luadbi/dbd/ directory.. 3) get sure to has the lua-odbc lua lib available and working in the lua system libs

ugh? @mwild1 @sparked435 ? please confirm cos i plan to package it inside debian or at leas provide packages for..

also if the lua-odbc-dbi its just a wrapper.. why not include it here ? i mean if you cannot .. please do you will accept a PR to propetry include it?

sparked435 commented 2 years ago

umm so this must be available as lua lib to be able to use the odbc module of dbi i guess?

Exactly correct.

so the ODBC module inside DBI is just a wrapper for ODBC lua lib separate project?

Yes.

if both prevouos are true then i guess: put the luadbi-odbc-scm-0.rockspec inside the root of the luadbi sources.. put the odbc.lua file inside the luadbi/dbd/ directory.. get sure to has the lua-odbc lua lib available and working in the lua system libs

This sounds correct to me.

also if the lua-odbc-dbi its just a wrapper.. why not include it here ? i mean if you cannot .. please do you will accept a PR to propetry include it?

I'm not opposed to including odbc.lua directly into this project. I don't remember how exactly DBI got to this state of ODBC support; I think it may have simply been that @moteus never asked for the shim to be included and I was busy with other things.

mckaygerhard commented 2 years ago

ok well .. i will first package the lau-odbc to property test and later send the PR as WIP ..

i guess in one week cos right now i am at job.. thanks for the instructions and guidelines