search

mwilensky768 / SSINS

BSD 2-Clause "Simplified" License
6 stars 7 forks source link

Windows unit tests failing #114

Closed mwilensky768 closed 2 years ago

mwilensky768 commented 2 years ago

The windows unit tests are failing because of permissions errors. It appears as if the test output files are not being properly closed after writing. I currently have no leads on this and will need to investigate further.

mwilensky768 commented 2 years ago

The failing unit tests occur only on the python 3.8 and 3.9 builds, and it seems to be specifically the uvfits writer, as the write tests for the INS class are working fine. Coincidentally, the 3.8 and 3.9 builds use pyuvdata 2.2.9 since support for 3.7 was dropped in 2.2.8. Currently testing on a ci update branch to see if the pyuvdata version matters.

mwilensky768 commented 2 years ago

The windows builds succeeded using pyuvdata 2.2.8.

mwilensky768 commented 2 years ago

This is probably related to the fact that pyuvdata 2.2.9 updates the astropy dependency, and astropy is having some sort of issue with this. Bryna Hazelton suggests that some new unit test archcitecture (namely the tmp_path fixture) might help avoid this problem since the test itself won't involve the manual deleting of the file (which is not a feature that is intended to be tested by any unit test since it is not the primary purpose of this code and is really a problem stemming from a dependency's behavior).

mwilensky768 commented 2 years ago

Closed by #116