search

mwitkow / go-proto-validators

Generate message validators from .proto annotations.
Apache License 2.0
1.08k stars 164 forks source link

Do not force dependants to depend on bazel_gazelle #117

Closed fmeum closed 1 year ago

fmeum commented 2 years ago

By loading the "gazelle" rule from @bazel_gazelle in the top-level build file, all users of targets in that file have to depend on bazel_gazelle. This is particular problematic for rules_go, which depends on //:validators_golang but should not depend on bazel_gazelle.

This is resolved by moving the gazelle rule definition into a separate Bazel package.

fmeum commented 2 years ago

Friendly ping, can this be reviewed?

fmeum commented 1 year ago

@devnev @Helcaraxan Friendly ping. Could you review this change? It's very small, but would unblock using this package with Bazel's new external dependency management.

fmeum commented 1 year ago

@devnev Thanks for the approval! Could you merge?