search

mwitkow / go-proto-validators

Generate message validators from .proto annotations.
Apache License 2.0
1.09k stars 164 forks source link

Add full import path to go_package option #85

Closed doriandekoning closed 4 years ago

doriandekoning commented 4 years ago

When currently using protoc I get the following warning:

2020/04/14 17:07:18 WARNING: Deprecated use of 'go_package' option without a full import path in "github.com/mwitkow/go-proto-validators/validator.proto", please specify:
    option go_package = "github.com/mwitkow/go-proto-validators;validator";
A future release of protoc-gen-go will require the import path be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

This small change fixes this warning for me.

As far as I know this is not a breaking change. The web page mentioned by this warning the following states: The Go package name of generated code will be the last path component of the go_package option..

jcorry commented 4 years ago

Can we merge this and release?

2020/05/16 20:47:11 WARNING: Deprecated use of 'go_package' option without a full import path in "github.com/mwitkow/go-proto-validators/validator.proto", please specify: option go_package = "github.com/mwitkow/go-proto-validators;validator"; A future release of protoc-gen-go will require the import path be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

cprates commented 4 years ago

I was having this same issue and this solves it. Any chance of merging this PR?

cyx commented 4 years ago

Same. Bump?

Helcaraxan commented 4 years ago

Hello all.

First of all many thanks for the contribution. It is greatly appreciated. :ok_hand:

Second, my sincere apologies for the belated response. I am spread pretty thin and this repository had fallen of my radar for a moment. Merging this now and I'll tag a new patch release with this fix integrated.