search

mwitkow / go-proto-validators

Generate message validators from .proto annotations.
Apache License 2.0
1.09k stars 164 forks source link

bugfix: add not embed to nullable condition #90

Closed onionsheep closed 4 years ago

onionsheep commented 4 years ago

nullable condition limited to gogoproto.IsNullable, add !gogoproto.IsEmbed to condition to fix this.

Helcaraxan commented 4 years ago

Hello. Thank you for the PR!

Would you be able to add a regression testcase for this as well in your changes? As soon as that's done we can merge this. :slightly_smiling_face:

onionsheep commented 4 years ago

Hello. Thank you for the PR!

Would you be able to add a regression testcase for this as well in your changes? As soon as that's done we can merge this. 🙂

a signle field testcase is added for both golang and gogo.