mwittig / node-milight-promise

A node module to control Milight LED bulbs and OEM equivalents such as Rocket LED, Limitless LED Applamp, Easybulb, s`luce, iLight, iBulb, and Kreuzer
MIT License
114 stars 27 forks source link

Correct commands, add RGBW night mode, and cleanup #1

Closed dotsam closed 9 years ago

dotsam commented 9 years ago

There were a few errors in the commands.js file pulled from applamp, and it did not implement night mode on RGBW bulbs (compatible with v4 bridge only). Correct info pulled from http://www.limitlessled.com/dev/

mwittig commented 9 years ago

Hi @dotsam, Thank you very much for your contribution, much appreciated! I am currently on the road and I'll look into this on Friday.

dotsam commented 9 years ago

Hi Marcus, did you have a chance to look at this? I'd like to use some of the changes I've made here in another project which references your npm package.

mwittig commented 9 years ago

Hi Sam, sorry for the slow progress at my end. I have reviewed your changes by comparing it with the reference list at LimitlessLED and I did some testing with the RGBW lamps. So, everything looks right to me. Thank you very much again for taking your time to fix the code, on particular for white bulbs which I don't have. I am surprised that the source from AppLamp.nl contains so many errors. I have just checked the source at http://www.applamp.nl/service/applamp-api/ and the bug are still in there. Thus, I'll use the LimitlessLED for future reference.