search

mwittig / node-milight-promise

A node module to control Milight LED bulbs and OEM equivalents such as Rocket LED, Limitless LED Applamp, Easybulb, s`luce, iLight, iBulb, and Kreuzer
MIT License
114 stars 27 forks source link

Fix the "no response timeout" issue #69

Closed CliffS closed 4 years ago

CliffS commented 4 years ago

It appears that the result (resolve or reject) is ignored several levels higher. Thus the simple fix without major rewriting of the code is to resolve on a "no response timeout" rather than rejecting.

mwittig commented 4 years ago

Thanks you very much for your efforts in investigating the issue. I have reviewed your code changes carefully, but I unfortunately the changes do not seem to solve the underlying issue. I am now developing solution for this which takes in account your findings. I am closing the PR now as it breaks the builds.