search

mwittig / npm-license-crawler

Analyzes license information for multiple node.js modules (package.json files) as part of your software project.
BSD 3-Clause "New" or "Revised" License
233 stars 45 forks source link

Development/Production options #29

Open sebastianhaas opened 5 years ago

sebastianhaas commented 5 years ago

It appears to me that the production and development options are not implemented in the way they are documented. While I can see the readme was modified in this commit, I can't seem to find the options in the source code.

Would you accept a PR that fixes that?

sebastianhaas commented 5 years ago

Edit: It is checked, at least somehow, if the directDependencies flag is set. But also in that case, it is not implemented as documented.

mwittig commented 5 years ago

Hi Sebastian, sorry for delay in reply. PRs are always welcome and highly appreciated!

On the matter I have contacted the original submitter of PR #26 to check if he has some uncommitted changes or he forgot to push some changes to his fork.

CSobol commented 5 years ago

Can confirm this doesn't work as advertised.

This tool is really useful once a year when we audit our open source software usage, so I'll put some work in on it.

NikhilVerma commented 5 years ago

Seems like it's using an old dependency for licence checker which doesn't even support --production