search

mwittig / pimatic-amazing-dash-button

Pimatic plugin for Amazon's dash-buttons
GNU Affero General Public License v3.0
14 stars 1 forks source link

discover filter #2

Closed n3roGit closed 8 years ago

n3roGit commented 8 years ago

please add a MAC discovery filter with "AC:63:BE:". at the moment my fire hd with "A0:02:DC:" would be detected as dash :D

mwittig commented 8 years ago

Thanks for your report. "AC:63:BE:" is already part of the list of filtered vendor ids. Actually, the code filters for all vendor ids, registered with IEEE by Amazon. Currently, there is no info on which subset of vendor ids is used for dash-buttons. See also https://github.com/mwittig/pimatic-amazing-dash-button/blob/master/amazing-dash-button.coffee#L67-L71

Regarding vendor id AC:63:BE: doesn't auto discovery work for your dash button? This would be strange as it is working for me and my dash-button has the same MAC vendor id. Does your dash-button work at all with the plugin? If not, you may need to provide the IP-address assigned to network interface which should be used to capture dash-button ARP requests. See also https://github.com/mwittig/pimatic-amazing-dash-button#plugin-configuration

n3roGit commented 8 years ago

Yes it works with auto discover :)

mwittig commented 8 years ago

OK, that's great. So, I am closing this ticket now. Please re-open if you want to follow up on this.

I'll add a note to README, that auto discovery will detected "false positives" if other Amazon devices are on the network. Hopefully, there will be some some information available soon about the subset of vendor ids used for dash-buttons.

mwittig commented 8 years ago

If you like this plugin, please consider ★ starring the project on github. Thanks!