This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of bluebird-retry.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Added support for a predicate option that uses bluebird's filtered catch so that only errors matching a particular type or predicate function cause the operation to retry.
Reworked the error handling to handle the case where the function rejects with a non-Error object and to no longer replace the timeout error stack with the original error's stack.
Hello lovely humans,
bluebird-retry just published its new version 0.7.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of bluebird-retry. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
GitHub Release
predicate
option that uses bluebird's filtered catch so that only errors matching a particular type or predicate function cause the operation to retry.The new version differs by 9 commits .
1ff8557
0.7.0
58ac60f
update changelog for 0.7.0 release
996c0d7
clean up error formatting when the operation times out
db8a67f
Merge pull request #29 from demmer/handle-non-error-rejections
b16c913
Merge pull request #28 from demmer/predicate-catch
59fc0fb
handle the case where the function rejects with a non-error
5a8507e
rework the predicate implementation to support predicate functions
c4cc75d
Make it possible to retry only upon errors that are eligible by the predicate option
96a6a0e
test: add check that the return value is propagated
See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? :zap:
greenkeeper upgrade