search

mwittig / pimatic-milight-reloaded

A pimatic plugin to control Milight LED lights and its OEM equivalents such as Rocket LED, Limitless LED Applamp, Easybulb, s`luce, iLight, iBulb, and Kreuzer
GNU General Public License v2.0
7 stars 2 forks source link

RGBW color saturation #16

Open balert opened 6 years ago

balert commented 6 years ago

I've tried and successfully changed color saturation of my bulbs using the node-milight-promise library directly, i.e. my bulbs apparently support saturation control. As written in the readme, saturation control is not yet supported by this pimatic plugin, though. Is there some work in progress? I'd be willing to help ...

balert commented 6 years ago

I've managed to get saturation working in a fork of this project (https://github.com/balert/pimatic-milight-reloaded).

mwittig commented 6 years ago

That's great. I'll review your code as soon as I can. It'll take a a few days as I am currently very busy

EDIT: I have just quickly reviewed your code and I think some more work is need with regards to the "set saturation" action handler. I'll get back to this soon. Please also note, the "set color" action will also set saturation based on the result of the RGB to HSV transformation