search

mwittig / pimatic-milight-reloaded

A pimatic plugin to control Milight LED lights and its OEM equivalents such as Rocket LED, Limitless LED Applamp, Easybulb, s`luce, iLight, iBulb, and Kreuzer
GNU General Public License v2.0
7 stars 2 forks source link

MilightWWCWZone should extend from env.devices.DimmerActuator? #6

Closed michbeck100 closed 7 years ago

michbeck100 commented 7 years ago

I've seen that MilightWWCWZone has methods to dim the light. Why does this class extend from env.devices.SwitchActuator instead of env.devices.DimmerActuator?

mwittig commented 7 years ago

Because env.devices.DimmerActuator only provides support for setting absolute dimming values. However, the MilightWWCWZone control layer only supports relative changes, ie. dim up/down.

I thought about emulating absolute dimming, but this would result in sending 38 commands in the worst case for a single dim value.