mwittrien / BetterDiscordAddons

A series of plugins and themes for BetterDiscord.
GNU General Public License v2.0
2.12k stars 3.84k forks source link

[BUG] - ImageUtilities - Gallery mode cannot display GIFs #1625

Closed bestpika closed 2 years ago

bestpika commented 2 years ago

Describe the bug

In gallery mode, if the current image is a GIF, nothing will be displayed.

To Reproduce

  1. Click on any image that is not a GIF.
  2. Use the keyboard arrow keys to navigate back and forth to any GIF file that has not been opened.

Expected behavior

It should be displayed as if you clicked directly on the GIF image file.

Screenshots

Because the server is more private so I'll explain. When visiting a GIF that has not been opened, there is nothing in the middle, just blackness.

Discord Build (stable, ptb or canary):

Discord | Stable 133074 (7e76a26) BetterDiscord | 1.5.3

Additional context

mwittrien commented 2 years ago

Works just fine for me

mwittrien commented 2 years ago

Can u take a video

bestpika commented 2 years ago

I just confirmed that all the GIFs that can't be displayed are GIFs converted from imgur links. This type of GIF looks the same as a normal GIF on Discord unless you click on the URL. I can guarantee 100% reproduction. image image image

You can try the links below. https://i.imgur.com/LaNagry

mwittrien commented 2 years ago

Can u screenshot your settings for ImageUtilities It works fine for me

bestpika commented 2 years ago

This is my config.

{
    "all": {
        "detailsSettings": {
            "footnote": false,
            "tooltip": false,
            "tooltipDelay": 0
        },
        "engines": {
            "_all": true,
            "Baidu": true,
            "Bing": true,
            "Google": true,
            "ImgOps": true,
            "IQDB": true,
            "Reddit": true,
            "SauceNAO": true,
            "Sogou": true,
            "TinEye": true,
            "WhatAnime": true,
            "Yandex": true
        },
        "general": {
            "nsfwMode": true
        },
        "ownLocations": {
            "Downloads": {
                "enabled": true,
                "location": "R:\\tmp"
            }
        },
        "places": {
            "userAvatars": true,
            "groupIcons": true,
            "guildIcons": true,
            "emojis": true
        },
        "rescaleSettings": {
            "imageViewer": "WINDOW",
            "messages": "NONE"
        },
        "resizeSettings": {
            "imageViewer": true,
            "messages": false
        },
        "scaleSettings": {
            "messages": "NONE",
            "imageViewer": "NONE"
        },
        "viewerSettings": {
            "zoomMode": false,
            "galleryMode": true,
            "details": false,
            "copyImage": false,
            "saveImage": false
        },
        "zoomSettings": {
            "pixelMode": false,
            "zoomLevel": 2,
            "lensSize": 200
        }
    }
}
bestpika commented 2 years ago

In imgur's GIF directly open the URL will be in the file name after more than a mp4, direct click will become a file download, there may be because of this reason? image

mwittrien commented 2 years ago

No clue, works fine for me

bestpika commented 2 years ago

I found that just turning on the options marked in the image caused the aforementioned problem. image

mwittrien commented 2 years ago

Alright ill check later