Closed ChuckBTaylor closed 4 months ago
Just looking through it, have some ideas for clean up:
Make roles and genres one list (instead of two lists combined later). Current Figma file has all categories as one group.
const subheaderLinkItems: SubheaderLinksProps[] = [ { items: roles, navigate }, { items: genres, navigate }, ]
Refactor to get rid of SubheaderLinks component. I think it be NavLinks and then another NavLinks. The styling for them is the same. Also the verbiage for SubheaderLinks is confusing now since we don't have "Subheaders" any more.
SubheaderLinks
NavLinks
100%. The Subheader part was created when ROLE and GENRE subheaders were present.
Definite refactor and clean up here.
Oh ya. No questions as to why it is that way.
Closed in #102
Just looking through it, have some ideas for clean up:
Make roles and genres one list (instead of two lists combined later). Current Figma file has all categories as one group.
Refactor to get rid of
SubheaderLinks
component. I think it beNavLinks
and then anotherNavLinks
. The styling for them is the same. Also the verbiage forSubheaderLinks
is confusing now since we don't have "Subheaders" any more.